stake: Minor improvements in IsTreasuryX tests.#3694
Merged
Conversation
davecgh
requested changes
May 17, 2026
jholdstock
force-pushed
the
is_treasury-review
branch
from
076048f to
8d665b8
Compare
Fix a couple of comment typos in recent refactoring of the tests for IsTAdd, IsTreasuryBase and IsTSpend funcs.
jholdstock
force-pushed
the
is_treasury-review
branch
from
8d665b8 to
1c93fe0
Compare
davecgh
approved these changes
May 18, 2026
Member
Author
|
This PR ended up a bit thin but we can merge it like this if you are happy to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was late to the party reviewing these recent changes but I've taken a look anyway and here are a few minor things I noticed could be improved.
Using t.Run takes advantage of go tooling to prefix test error messages with the test name, rather than having to manually constructing the strings.